test header capture #895
Open
test header capture #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainJuge
commented
Nov 26, 2025
| import java.util.List; | ||
|
|
||
| public interface ElasticAttributes { | ||
| AttributeKey<Long> SELF_TIME = AttributeKey.longKey("elastic.span.self_time"); |
Member
Author
There was a problem hiding this comment.
[for reviewer] no longer used, thus we can remove it.
| @@ -1,48 +0,0 @@ | |||
| ### Breakdown metrics | |||
|
|
|||
| Status: feature has been disabled and code is only kept for future reference. | |||
Member
Author
There was a problem hiding this comment.
[for reviewer] not relevant anymore, if the feature gets re-implemented in the future we'll re-implement it from scratch.
| .start(); | ||
| process.waitFor(5, TimeUnit.SECONDS); | ||
| return process.exitValue() == 0; | ||
| boolean processExit = process.waitFor(5, TimeUnit.SECONDS); |
Member
Author
There was a problem hiding this comment.
[for reviewer] fixing minor bug when trying to debug the remote app running in docker.
|
|
||
| @RestController | ||
| @RequestMapping("/messages") | ||
| public class MessagingController { |
Member
Author
There was a problem hiding this comment.
[for reviewer] adding an HTTP controller to receive/send messages with JMS API.
| @@ -0,0 +1,2 @@ | |||
| # use an in-process activemq artemis instance | |||
| spring.artemis.mode=embedded | |||
Member
Author
There was a problem hiding this comment.
[for reviewer] provides an in-process ActiveMQ Artemis instance, the implementation is provided by the artemis-jms-server dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #879 by adding explicit test of the upstream implementation.
otel.instrumentation.messaging.experimental.capture-headersconfiguration and relatedmessaging.header.span attribute prefix is used and tested in the following messaging instrumentation, so we can assume it's supported:All the instrumentations marked with * are the ones that are originally supported for the classic agent.